This repository was archived by the owner on Jan 28, 2020. It is now read-only.
Fixed comparison of FileFields to strings. #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #376 Also explicitly sorts instead of depending on chance.
There was a problem hiding this comment.
The important part of this change is the addition of .name to the asset.
There was a problem hiding this comment.
What was it doing before? Coercing FileField to a string before comparison?
There was a problem hiding this comment.
I don't know. I assume it was, and maybe still does on some machines. It just broke for me on a fresh installation. In any case, this is more explicit.
noisecapella
added a commit
that referenced
this pull request
Jul 17, 2015
Fixed comparison of FileFields to strings.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #376
Also explicitly sorts instead of depending on chance.