This repository was archived by the owner on Jan 28, 2020. It is now read-only.
Fixed display of vocabulary terms containing spaces. #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ShawnMilo
commented
Jul 17, 2015
ShawnMilo
commented
There was a problem hiding this comment.
These changes belong to commit #377; hopefully it'll be merged before this one.
search/search_indexes.py
Outdated
fixes #376 Also explicitly sorts instead of depending on chance.
fixes #367 I spent some (too much) time on the command line using the elasticsearch module trying to figure out how to fix the search to work with spaces. In the end, I went for the obvious, lame solution. Eventually it seems like we'll want to ditch Haystack and use Elasticsearch directly.
ShawnMilo
force-pushed
the
bug/skm/367_term_spaces
branch
from
967e856 to
cafe20c
Compare
|
This look good to me. @pdpinch agreed to merge as it is and open another issue |
giocalitri
added a commit
that referenced
this pull request
Jul 17, 2015
Fixed display of vocabulary terms containing spaces.
|
@giocalitri #384 added. Perhaps base64 encoding will be the silver bullet. |
|
Without complicating this further, I suggest we only allow users to provide alphanumeric term names |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.