-
Notifications
You must be signed in to change notification settings - Fork 3
mitx - only ingest published courses #1102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rhysyngsun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach works for things going forward, but it doesn't address:
- Removing the currently non-live courses from MIT Open (arguably we could run a one-off script for this)
- In the future should a course be accidentally published and then unpublished
So it's probably a more reliable approach to instead add live and page.live to the computation of published in _transform_course.
|
@shanbady can you give me a high-level description of what the criteria are for including courses here? |
|
@pdpinch at a high level we are including all courses that are published. On mitx that means we have to set "live=true" and "page_live=true" otherwise we would pull down courses that appear published but should not be. |
rhysyngsun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/4579
Description (What does it do?)
Makes it so that when we fetch from mitx we dont pull in courses that are unpublished
How can this be tested?
./manage.py backpopulate_mitxonline_data