Append /static to the front of the testimonial marketing card image
#1115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkachel
added
Needs Review
jonkafton
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
n/a
Description (What does it do?)
The marketing images aren't showing on production - it turns out the image URLs need to be prepended with
/staticto work in the deployed environment. (This is not the case for local deployments at the moment so this wasn't caught in testing.) This just does that.How can this be tested?
View the homepage and verify the image URLs start with
/staticand that the images appear. (They should still appear - your local deployment should be able to serve the images up with or without the/static.)