Skip to content

Shanbady/navigation UI fixes #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Shanbady/navigation UI fixes #1119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a95b14
adding border to header and removing double border from side nav
shanbady Jun 18, 2024
55997dd
removing border radius from login button
shanbady Jun 18, 2024
faa23b8
removing padding from buttons
shanbady Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontends/mit-open/src/page-components/Header/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import { useUserMe } from "api/hooks/user"
const Bar = styled(AppBar)(({ theme }) => ({
height: "60px",
padding: "0 8px",
borderBottom: `1px solid ${theme.custom.colors.lightGray2}`,
backgroundColor: theme.custom.colors.white,
color: theme.custom.colors.darkGray1,
display: "flex",
Expand Down
3 changes: 1 addition & 2 deletions frontends/mit-open/src/page-components/Header/UserMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const UserMenuContainer = styled.button({
})

const LoginButtonContainer = styled(FlexContainer)(({ theme }) => ({
paddingRight: "32px",
paddingRight: "16px",
"&:hover": {
textDecoration: "none",
},
Expand Down Expand Up @@ -159,7 +159,6 @@ const UserMenu: React.FC<UserMenuProps> = ({ variant }) => {
<FlexContainer className="login-button-desktop">
<ButtonLink
data-testid="login-button-desktop"
edge="circular"
size="small"
reloadDocument={true}
href={loginUrl}
Expand Down
1 change: 1 addition & 0 deletions frontends/ol-components/src/components/NavDrawer/NavDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ const NavDrawer = (props: NavDrawerProps) => {
hideBackdrop={true}
PaperProps={{
sx: {
borderRight: "none",
boxShadow: "0px 6px 24px 0px rgba(37, 38, 43, 0.10)",
zIndex: (theme) => theme.zIndex.appBar - 1,
overscrollBehavior: "contain",
Expand Down