Skip to content

Conversation

@abeglova
Copy link
Contributor

@abeglova abeglova commented Jun 18, 2024

What are the relevant tickets?

None

Description (What does it do?)

Ferdi asked for the default sort to sort by popularity instead of new

So the sort is now by is_learning_material (false first) then popularity

How can this be tested?

Go to http://localhost:8063/search verify that the sort order is the same as http://localhost:8063/search?sortby=-views with everything that isn't a course or program excluded

If you search by text, the search should continue to be by relevance

@abeglova abeglova marked this pull request as ready for review June 18, 2024 19:22
@shanbady shanbady self-requested a review June 18, 2024 19:23
Copy link
Contributor

@shanbady shanbady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@abeglova abeglova merged commit b93f4b1 into main Jun 18, 2024
This was referenced Jun 20, 2024
@rhysyngsun rhysyngsun deleted the ab/use-popular-in-default-sort branch February 7, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants