Updates to page titles #1121
Merged
Updates to page titles #1121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanbady
requested changes
Jun 20, 2024
Contributor
shanbady
left a comment
shanbady
left a comment
There was a problem hiding this comment.
works as intended. left a minor nitpick
shanbady
added
Waiting on author
and removed
Needs Review
shanbady
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes Page titles in Unified/Open #4510
Description (What does it do?)
SITE_NAME, defaults to "MIT Open"|Also updates titles:
How can this be tested?
Navigate through site and confirm page title updated in tab and appears in history and bookmarks.
Lighthouse report passes title checks (post RC release? not tested)