Skip to content

removing check for live attribute #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2024
Merged

removing check for live attribute #1128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f71efb
removing check for live attribute
shanbady Jun 20, 2024
a0d6cca
fixing tests
shanbady Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion learning_resources/etl/mitxonline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,6 @@ def _transform_course(course):
"published": bool(
parse_page_attribute(course, "page_url")
and parse_page_attribute(course, "live")
and course.get("live", False)
), # a course is only considered published if it has a page url
"professional": False,
"certification": has_certification,
Expand Down
2 changes: 0 additions & 2 deletions learning_resources/etl/mitxonline_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,6 @@ def test_mitxonline_transform_programs(
"published": bool(
course_data.get("page", {}).get("page_url", None)
and course_data.get("page", {}).get("live", None)
and course_data.get("live", None)
),
"certification": True,
"certification_type": CertificationType.completion.name,
Expand Down Expand Up @@ -308,7 +307,6 @@ def test_mitxonline_transform_courses(settings, mock_mitxonline_courses_data):
"published": bool(
course_data.get("page", {}).get("page_url", None)
and course_data.get("page", {}).get("live", None)
and course_data.get("live", None)
),
"professional": False,
"certification": parse_certification(
Expand Down