resource category #1188
Merged
resource category #1188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeglova
commented
Jun 28, 2024
| }, | ||
| }, | ||
| "free": {"type": "boolean"}, | ||
| "is_learning_material": {"type": "boolean"}, |
Contributor
Author
There was a problem hiding this comment.
is_learning_material is staying in the index (but not shown in the results) since it is used in the default search. I forgot to add it to the mapping previously
ChristopherChudzicki
approved these changes
Jun 28, 2024
Contributor
ChristopherChudzicki
left a comment
ChristopherChudzicki
left a comment
There was a problem hiding this comment.
LGTM 👍 Just the suggestion about underscore vs space
learning_resources/constants.py
Outdated
| video_playlist = "Video Playlist" | ||
|
|
||
|
|
||
| LEARNING_MATERIAL_RESOURCE_CATEGORY = "learning material" |
Contributor
There was a problem hiding this comment.
Suggested change
| LEARNING_MATERIAL_RESOURCE_CATEGORY = "learning material" | |
| LEARNING_MATERIAL_RESOURCE_CATEGORY = "learning_material" |
abeglova
force-pushed
the
ab/resource_category
branch
from
27481da to
b5b76b4
Compare
Member
|
pre-commit.ci run |
This was referenced Jul 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
closes https://github.com/mitodl/hq/issues/4727
Description (What does it do?)
This pr adds resource_category as a serializer field and a filter for the /learning_resource and /learning_resources_search apis. It removes is_learning_material as a filter and aggregation for /learning_resources_search
How can this be tested?
Run docker-compose run web ./manage.py recreate_index --all
Go to http://localhost:8063/api/v1/learning_resources/
Verify that the resource_category filter works, for example http://localhost:8063/api/v1/learning_resources/?resource_category=learning+material
Got to http://localhost:8063/api/v1/learning_resources_search
Verify that the resource_category filter works, for example http://localhost:8063/api/v1/learning_resources_search/?resource_category=learning+material
Verify that aggregations work with resource_category http://localhost:8063/api/v1/learning_resources_search/?aggregations=resource_category
Go to http://localhost:8063/api/v1/schema/redoc and verify that the documentation looks good