resource category tabs #1211
Merged
resource category tabs #1211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeglova
added
Blocked
Needs Review
abeglova
force-pushed
the
ab/update-resource-tabs
branch
from
14782e7 to
192ced8
Compare
shanbady
requested changes
Jul 2, 2024
Contributor
shanbady
left a comment
shanbady
left a comment
There was a problem hiding this comment.
It seems that when i navigate from the homepage the url is referencing tabs and the correct thing isnt highlighted in results
shanbady
added
Waiting on author
and removed
Needs Review
shanbady
approved these changes
Jul 2, 2024
Contributor
shanbady
left a comment
shanbady
left a comment
There was a problem hiding this comment.
appears to work as needed
abeglova
force-pushed
the
ab/update-resource-tabs
branch
from
0cc4e88 to
8e26351
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
closes https://github.com/mitodl/hq/issues/4728
Description (What does it do?)
This replaces the current logic for the resource tabs with data from the new resource_category field
This should be reviewed with https://github.com/mitodl/course-search-utils/pull/117/files which needs to be released first
Screenshots (if appropriate):
NA
How can this be tested?
Run ./manage.py recreate_index --all if you don't have resource_category in your search index
Go to http://localhost:8063/search and verify that the resource tabs work as expected
Go to http://localhost:8063/c/unit/ocw and verify that the resource tabs work as expected
Additional Context
This can already be reviewed, however it depends on mitodl/course-search-utils#117 which depends on releasing #1188 and updating axios
Also recreate_index is needs to run on prod before this can be merged so the resource_category field is updated in the search index
DO NOT MERGE UNTILresource category #1188 is releaseddonerecreate_index is run on prod@mitodl/open-api-axios is updateddoneAdd resource category to facets course-search-utils#117 is updated to use the params from the updated @mitodl/open-api-axiosdonecourse-search-utils is released with Add resource category to facets course-search-utils#117This pr is updated to point to the released version of course-search-utils instead of a branchThis is ready to merge once approved