Skip to content

Conversation

@jonkafton
Copy link
Contributor

@jonkafton jonkafton commented Jun 28, 2024

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/4715

Description (What does it do?)

  • Updates CTA text and URL for podcast episodes.
  • (also updates the info section icons, later realizing this is in flight)

Screenshots (if appropriate):

image

How can this be tested?

Open the Learning Resource Drawer for a podcast

@jonkafton jonkafton changed the title Jk/4715 podcast button Update resource drawer text and URL for podcast episodes Jun 28, 2024
@jonkafton jonkafton added the Needs Review An open Pull Request that is ready for review label Jun 28, 2024
@ChristopherChudzicki ChristopherChudzicki self-assigned this Jul 3, 2024
Copy link
Contributor

@ChristopherChudzicki ChristopherChudzicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though there's a merge conflict on the order of imports.

@jonkafton jonkafton force-pushed the jk/4715-podcast-button branch from 0197251 to 5eeb36d Compare July 8, 2024 13:52
@jonkafton jonkafton merged commit 3a953c2 into main Jul 8, 2024
@odlbot odlbot mentioned this pull request Jul 10, 2024
27 tasks
mbertrand pushed a commit that referenced this pull request Jul 15, 2024
* Select podcast episode URL for link button. Update/improve tests

* Update icons

* Type fix
@rhysyngsun rhysyngsun deleted the jk/4715-podcast-button branch February 7, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review An open Pull Request that is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants