Webpack build config loads .env files for running outside of Docker #1221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (What does it do?)
Uses the
dotenvpackage to read the .env files when running outside of Docker. Inside Docker, they are supplied on the Docker Compose run config.This is to accommodate the recent and excellent cleanup of env var handling: #1179
Checks that the
ENVIRONMENTis"local"before reading in the .env files.Also sets the Webpack dev server to use host 0.0.0.0.
How can this be tested?
This also sets the
ENVIRONMENTtodockerforyarn run watch:docker. It was set to this at some point previously, though if we see issues, that would be the most likely cause.