Skip to content

Webpack build config loads .env files for running outside of Docker #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Webpack build config loads .env files for running outside of Docker #1221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a8b00a4
Add .env file paths for running outside of docker
jonkafton Jul 2, 2024
9b1885a
Conditionally load env files if not in docker
jonkafton Jul 2, 2024
70f921d
Local only - we don't want to load in for builds
jonkafton Jul 2, 2024
c661745
Use host 0.0.0.0 for the dev server always
jonkafton Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontends/mit-open/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"scripts": {
"watch": "NODE_ENV=development ENVIRONMENT=local webpack serve",
"watch:docker": "API_DEV_PROXY_BASE_URL=http://nginx:8063 NODE_ENV=development ENVIRONMENT=local webpack serve",
"watch:docker": "API_DEV_PROXY_BASE_URL=http://nginx:8063 NODE_ENV=development ENVIRONMENT=docker webpack serve",
"watch:rc": "API_DEV_PROXY_BASE_URL=https://api.mitopen-rc.odl.mit.edu/ NODE_ENV=development ENVIRONMENT=local webpack serve",
"build": "webpack --config webpack.config.js --bail",
"build-exports": "webpack --config webpack.exports.js --bail",
Expand Down
18 changes: 14 additions & 4 deletions frontends/mit-open/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,18 @@
/* eslint-disable @typescript-eslint/no-var-requires */
const path = require("path")
require("dotenv").config({
path: path.resolve(__dirname, "../../.env"),
})

if (process.env.ENVIRONMENT === "local") {
console.info("Loading environment from .env files")
require("dotenv").config({
path: [
path.resolve(__dirname, "../../env/frontend.local.env"),
path.resolve(__dirname, "../../env/frontend.env"),
path.resolve(__dirname, "../../env/shared.local.env"),
path.resolve(__dirname, "../../env/shared.env"),
path.resolve(__dirname, "../../.env"),
],
})
}

const webpack = require("webpack")
const BundleTracker = require("webpack-bundle-tracker")
Expand Down Expand Up @@ -258,7 +268,7 @@ module.exports = (env, argv) => {
devMiddleware: {
writeToDisk: true,
},
host: ENVIRONMENT === "docker" ? "0.0.0.0" : "::",
host: "0.0.0.0",
proxy: [
{
context: [
Expand Down