Align departments listing colors to designs #1238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherChudzicki
approved these changes
Jul 9, 2024
|
|
||
| return ( | ||
| <Page> | ||
| <div> |
Contributor
There was a problem hiding this comment.
div is fine, but a fragment <>...</> would also work
ChristopherChudzicki
added
Waiting on author
and removed
Needs Review
rhysyngsun
force-pushed
the
nl/dept-listing-ux-fixes
branch
from
96afee5 to
b702937
Compare
mbertrand
pushed a commit
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/4780
Description (What does it do?)
Tweaks a few of the colors on the departments listing page. The header background looks like it was probably already addressed.
Screenshots (if appropriate):
Desktop screenshots
Mobile width screenshots
How can this be tested?
Go to the departments listing page and verify the background and item highlight colors match the designs.