Fix dialog spacing + reset AddToListDialog #1484
Conversation
ChristopherChudzicki
force-pushed
the
cc/dialog-spacing-and-reset
branch
from
bfc75c0 to
d14b551
Compare
| use: { | ||
| loader: "swc-loader", | ||
| options: { | ||
| jsc: { | ||
| experimental: { | ||
| plugins: [["@swc/plugin-emotion", {}]], | ||
| }, | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
This is https://www.npmjs.com/package/@swc/plugin-emotion
In particular, in dev mode, this gives us more useful class names. (production is unchanged).
Added in this PR in the course of trying to figure out where a style was coming from.
| alignItems: "start", | ||
| "> *": { | ||
| "> *:not(:last-child)": { | ||
| marginBottom: "4px", |
There was a problem hiding this comment.
This rule is supposed to make the 4px gap shown below. Note that there is no gap below the last child.
Figma:
ChristopherChudzicki
changed the title
| /** | ||
| * MUI Dialog's [TransitionProps](https://mui.com/material-ui/api/dialog/#props) | ||
| */ | ||
| TransitionProps?: DialogProps["TransitionProps"] |
There was a problem hiding this comment.
This should have been removed when we made the dialogs "Slide down from top".
ChristopherChudzicki
added
the
Needs Review
| {children} | ||
| {footerContent} |
There was a problem hiding this comment.
Anything that footerContent was used for can just be passed as part of the children.
(In a previous design, it needed to be separate)
| {mutation.isError && !formik.isSubmitting && ( | ||
| <Alert severity="error"> | ||
| There was a problem saving your list. Please try again later. | ||
| </Alert> | ||
| )} |
There was a problem hiding this comment.
Here's what it looks like now. Same as before.
|
|
||
| return ( | ||
| <Dialog | ||
| <FormDialog |
There was a problem hiding this comment.
I had considered using FormDialog, but at first it didn't seem necessary since this is barely a form and there's only one input element. This makes sense though, it cleans things up and onReset fixes our issue with the selections persisting.
What are the relevant tickets?
This is a followup to #1463
Description (What does it do?)
This does two things:
Screenshots (if appropriate):
Before / After
How can this be tested?