Skip to content

Conversation

@gumaerc
Copy link
Contributor

@gumaerc gumaerc commented Aug 29, 2024

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/5298

Description (What does it do?)

This PR addresses some changes to the homepage hero / search area that were not addressed as part of #1454.

Screenshots (if appropriate):

image
image

How can this be tested?

  • Spin up this branch of mit-learn
  • Visit the homepage at http://localhost:8062/
  • Verify that the changes from the issue have been addressed:
    • If you type something in the search box, the x button to clear your search should be narrower, but still the whole height of the text box with no hover state
    • The sizing of the search chips below the text box should be properly sized now, have the correct border / background colors and hover states and the correct icons
    • There should now be a drop shadow on the text box

@gumaerc gumaerc added the Needs Review An open Pull Request that is ready for review label Aug 29, 2024
Copy link
Contributor

@ChristopherChudzicki ChristopherChudzicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As mentioned in slack, I'm confused by the

We want to increase the size of the "x" that appears when user starts typing.

in the issue... but it seems to match the screenshot there. I can't find the X in figma.

@gumaerc gumaerc merged commit 9c7621c into main Aug 29, 2024
@odlbot odlbot mentioned this pull request Aug 30, 2024
4 tasks
@rhysyngsun rhysyngsun deleted the cg/homepage-hero-updates-2 branch February 7, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review An open Pull Request that is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants