Sort news by publish date #1522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbertrand
force-pushed
the
mb/news_sort_publish_dt
branch
from
f57de5d to
c7ad575
Compare
abeglova
approved these changes
Sep 6, 2024
Contributor
abeglova
left a comment
abeglova
left a comment
There was a problem hiding this comment.
Works great! I did get
Running sloan_webinars_etl pipeline
[2024-09-06 14:49:25] ERROR 1 [root] utils.py:132 - [6f3781a9a9cd] - unparsable date received - ignoring 'January - December 2024'
Traceback (most recent call last):
File "/src/news_events/etl/utils.py", line 128, in parse_date
.replace(tzinfo=ZoneInfo("US/Eastern"))
^^^^^^^
AttributeError: 'NoneType' object has no attribute 'replace'
Processed sloan_webinars_etl pipeline with 2 items
While running backpopulate_news_events but that's not related to your pr
mbertrand
force-pushed
the
mb/news_sort_publish_dt
branch
from
c7ad575 to
9d0b9a6
Compare
Member
Author
|
Thanks @abeglova , that error message is expected when sloan has a placeholder webinar with no particular date specified, and it should be skipped over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/5261
Description (What does it do?)
Sorts news items by publish date instead of created date
Screenshots (if appropriate):
How can this be tested?
.manage.py backpopulate_news_data