Skip to content

Conversation

@odlbot
Copy link
Contributor

@odlbot odlbot commented Sep 12, 2024

Nathan Levesque

renovate[bot]

Matt Bertrand

Carey P Gumaer

mbertrand and others added 19 commits September 6, 2024 12:14
* remove broken parent_topic_name API parameter and replace with parent_topic_id, fetch and display subtopics on topic channel pages

* fix typo

* fix existing tests

* test that subtopic chips appear properly

* mobile styles

* adjust desktop top padding

* move topic test to its own describe block

* regenerate openapi after rebase

* don't display subtopics section at all if there are no results

* filter out topics without a channel url

* adjust channel search box top margins

* put top padding on a wrapper container instead of margin on search input

* update spacing rules again

* use propsNotNil on channel_url

* simplify test

* remove waitFor

* remove conditional
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* add the buttons to the drawer

* add click handlers

* fix imports

* fix existing tests

* add a test that asserts the proper list buttons are shown in the resource drawer given a known authentication status

* make click handlers optional

* fix typecheck issue and only import user type

* test feedback

* only check is_learning_path_editor and remove unrealistic test case

* better conditional

* again, no need to check authentication status here
…#1260)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@gitguardian
Copy link

gitguardian bot commented Sep 12, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9430286 Triggered Generic Password 3bff381 docker-compose.yml View secret
9430286 Triggered Generic Password 3bff381 docker-compose.services.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants