-
Notifications
You must be signed in to change notification settings - Fork 3
Update docker-compose config to support OS cluster #1540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9430286 | Triggered | Generic Password | 06f8806 | docker-compose.yml | View secret |
| 9430286 | Triggered | Generic Password | 06f8806 | docker-compose.services.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
13fbdc7 to
86a67cf
Compare
shanbady
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codespaces appears to have issues. I think you may need to adjust the service name in the devcontainer.json
|
@shanbady addressed your feedback |
shanbady
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhysyngsun still appears to be some issue -
This is a working codespace note the ports visible and that the uwsgi process is bound to port 8061, the api server is exposed at 8063 and frontend at 8062.
On this branch there are only 2 ports that show up and uwsgi process is bound to 8063 instead of 8061
If you can get the port binding to look the same as in the first screenshot I think we will have a working setup. I recall not having to explicitly exposing or binding to 8061 (that somehow seemed to automatically happen) but the 8063 I had to bind via the PORT env var.
docker-compose.apps.yml
Outdated
| ports: | ||
| - "8061:8061" | ||
| depends_on: | ||
| # db: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stray comment and block
shanbady
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
091bed3 to
06f8806
Compare
What are the relevant tickets?
Part of https://github.com/mitodl/hq/issues/5179
Description (What does it do?)
This updates the docker compose setup to support running OpenSearch in a 3-node cluster locally.
How can this be tested?
docker compose upas usual without any additional configuration.docker compose stopif it's runningexport OPENSEARCH_CLUSTER_TYPE=clusterin your shelldocker compose up- you should see 3 opensearch nodes instead of 1manage.py recreate_index --allas the new cluster uses separate volumes to avoid breaking things if you switch back and forth.