Skip to content

Conversation

@gumaerc
Copy link
Contributor

@gumaerc gumaerc commented Sep 17, 2024

What are the relevant tickets?

Follow-up for https://github.com/mitodl/hq/issues/5386

Description (What does it do?)

This PR addresses an issue with #1545 where a class was used that was not properly defined addressing adornment buttons.

Screenshots (if appropriate):

Good:
Screenshot 2024-09-17 at 4 36 07 PM
Bad:
Screenshot 2024-09-17 at 4 36 56 PM

How can this be tested?

@gumaerc gumaerc added the Needs Review An open Pull Request that is ready for review label Sep 17, 2024
Copy link
Contributor

@ChristopherChudzicki ChristopherChudzicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ChristopherChudzicki
Copy link
Contributor

Merging for Carey, he's on vacation.

@ChristopherChudzicki ChristopherChudzicki merged commit 5cc7b5e into main Sep 18, 2024
This was referenced Sep 18, 2024
@rhysyngsun rhysyngsun deleted the cg/fix-search-adornment-buttons branch February 7, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review An open Pull Request that is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants