-
Notifications
You must be signed in to change notification settings - Fork 3
input / search input styling updates #1545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
de82b47 to
4be9d0a
Compare
ChristopherChudzicki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I did make a suggestion that I think we should do to keep the size styles more maintainable going forward. Let me know what you think.
| [theme.breakpoints.down("sm")]: { | ||
| height: "40px", | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the button padding certainly simplifies stuff 👍 Width is better.
I do worry that we will have a hard time keeping the mobile styles in sync. E.g., if someone updates the medium style, will they also remember to update large + breakpoint small?
I do think it would be better to put all the size-related styles into a sizeStyles, and re-use that at the smaller breakpoint (like what we do for buttons).
I think this does it: cg/search-box-updates-2...cg/search-box-updates-2-cc-suggestion#diff-11bf431b91ecb2c9d080ba7edb0f8f9518c9bed7b5fe9cf6154ecb1a835d5ac5L125
Note: In that diff, I made responsive optional and defaults to undefined ~ false. We could default it to "true" (which this PR effectively does) but I think we should consult Steve about that.
43363e6 to
a446259
Compare
ChristopherChudzicki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/5386
Description (What does it do?)
This PR makes changes to our
Inputelement to match some updates from Figma. We now have 4 sizes ofInput:The general style of the
Inputcontrol was updated to match the changes to the search input, andSearchInputwas moved intool-components. TheSearchInputcomponent implementsInputat theherosize on the home page and thelargesize on the search page and channel pages.Screenshots (if appropriate):
How can this be tested?
mit-learnon this branchInputelement and verify that everything looks right and matches Figma: https://storybook.learn.c4103.com/?path=/story/smoot-design-input--adornments