[NextJS] Load correct font and a few other global things #1583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherChudzicki
force-pushed
the
cc/nextjs-global-stuff
branch
from
1a77912 to
bc9b418
Compare
ChristopherChudzicki
force-pushed
the
nextjs
branch
from
98d37de to
9bab4f4
Compare
shanbady
approved these changes
Sep 19, 2024
Contributor
shanbady
left a comment
shanbady
left a comment
There was a problem hiding this comment.
approving - pending conflict resolution with nextjs
shanbady
requested changes
Sep 19, 2024
Contributor
shanbady
left a comment
shanbady
left a comment
There was a problem hiding this comment.
It seems the frontend doesnt come up in a codespace. its possible that some of the env variables need to get added to the env/codespaces.env
ChristopherChudzicki
force-pushed
the
cc/nextjs-global-stuff
branch
from
6bca115 to
3c6099e
Compare
Contributor
Author
Probably is env var issue. I think this is worth fixing, but we should handle it in a separate PR. |
shanbady
approved these changes
Sep 20, 2024
Contributor
shanbady
left a comment
shanbady
left a comment
There was a problem hiding this comment.
I'll create a separate issue for getting the codespaces to work. I'm guessing some of it may have to do with the hostname settings etc
ChristopherChudzicki
force-pushed
the
cc/nextjs-global-stuff
branch
from
3c6099e to
f08d8f9
Compare
jonkafton
pushed a commit
that referenced
this pull request
Sep 23, 2024
* load adobe font * add noindex based on MITOL_NOINDEX * add appzi script * validate env * comment, fix ci * build nextjs for production
jonkafton
pushed a commit
that referenced
this pull request
Sep 23, 2024
* load adobe font * add noindex based on MITOL_NOINDEX * add appzi script * validate env * comment, fix ci * build nextjs for production
jonkafton
pushed a commit
that referenced
this pull request
Sep 24, 2024
* load adobe font * add noindex based on MITOL_NOINDEX * add appzi script * validate env * comment, fix ci * build nextjs for production
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/5473
Description (What does it do?)
This PR:
NEXT_PUBLIC_APPZI_URL.How can this be tested?
View any page in the app and inspect text. Check that the Neue Haas Grotesk font is being used.
In your env file, set
NEXT_PUBLIC_APPZI_URL="https://w.appzi.io/w.js?token=Q2pSI"(this is not a secret env var, hence NEXT_PUBLIC and client side availability). Restart NextJS / Docker. The Appzi feedback form should appear on enter-right, just like prod.Set
MITOL_NOINDEX=truein your env file. and restart NextJS / Docker. The site should now include a noindex tag in<head>