Restore nextjs main workspace tests #1639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| describe("ProgramLetterDisplayPage", () => { | ||
| it("Renders a program letter from api", async () => { | ||
| // See https://github.com/mitodl/hq/issues/5694 | ||
| it.skip("Renders a program letter from api", async () => { |
Contributor
Author
There was a problem hiding this comment.
This failure was introduced after the tests started being skipped. It's not straightforward to fix—primarily because it's not straightforward to load relevant test data to verify any changes in the UI.
Contributor
There was a problem hiding this comment.
It looks like at some point the program letter intercept view (which is what actually generates the letter and passes the user along was removed along with tests for some reason. Fine with skipping this for now until we re-enable that
ChristopherChudzicki
added
the
Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Followup to 7d2de23#diff-6e015416135b772547f762a64d1f386d43e5b72aa74379ceff856aa36fd92292
Description (What does it do?)
The
jest.config.tsfile was erroneously deleted in 7d2de23#diff-6e015416135b772547f762a64d1f386d43e5b72aa74379ceff856aa36fd92292, which means themainworkspace tests on NextJs branch are urrently not running. This re-enables them.How can this be tested?
CI should pass