Skip to content

Restore nextjs main workspace tests #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Restore nextjs main workspace tests #1639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c321405
re-enable nextjs tests
ChristopherChudzicki Oct 2, 2024
b0d3a4e
re-enable tests on main workspace
ChristopherChudzicki Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontends/jest.jsdom.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const config: Config.InitialOptions &
"^.+\\.(t|j)sx?$": "@swc/jest",
},
moduleNameMapper: {
"\\.svg$": "ol-test-utilities/filemocks/svgmock.js",
"\\.(svg|jpg|jpeg|png)$": "ol-test-utilities/filemocks/imagemock.js",
"\\.(css|scss)$": "ol-test-utilities/filemocks/filemock.js",
},
rootDir: "./src",
Expand Down
15 changes: 15 additions & 0 deletions frontends/main/jest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import path from "path"
import type { Config } from "@jest/types"
import baseConfig from "../jest.jsdom.config"
const config: Config.InitialOptions = {
...baseConfig,
setupFilesAfterEnv: [
...baseConfig.setupFilesAfterEnv,
"./test-utils/setupJest.ts",
],
moduleNameMapper: {
...baseConfig.moduleNameMapper,
"^@/(.*)$": path.resolve(__dirname, "src/$1"),
},
}
export default config
3 changes: 2 additions & 1 deletion frontends/main/src/app-pages/ProgramLetterPage/[id]/view/ProgramLetter.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
}

describe("ProgramLetterDisplayPage", () => {
it("Renders a program letter from api", async () => {
// See https://github.com/mitodl/hq/issues/5694
it.skip("Renders a program letter from api", async () => {

Check warning on line 22 in frontends/main/src/app-pages/ProgramLetterPage/[id]/view/ProgramLetter.test.tsx

View workflow job for this annotation

GitHub Actions / javascript-tests 

Disabled test
Copy link
Contributor Author

@ChristopherChudzicki ChristopherChudzicki Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This failure was introduced after the tests started being skipped. It's not straightforward to fix—primarily because it's not straightforward to load relevant test data to verify any changes in the UI.

See https://github.com/mitodl/hq/issues/5694

Copy link
Contributor

@shanbady shanbady Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like at some point the program letter intercept view (which is what actually generates the letter and passes the user along was removed along with tests for some reason. Fine with skipping this for now until we re-enable that

const programLetter = factory.programLetter()
setup({ programLetter })
await waitFor(() => {
Expand Down
0 ...l-test-utilities/src/filemocks/svgmock.js → ...test-utilities/src/filemocks/imagemock.js
View file
Open in desktop
File renamed without changes.
Loading