bump course search utils #1672
Merged
bump course search utils #1672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherChudzicki
added
the
Needs Review
ChristopherChudzicki
force-pushed
the
cc/bump-course-search-utils
branch
from
e4f06c4 to
aad7d51
Compare
jonkafton
approved these changes
Oct 10, 2024
Contributor
jonkafton
left a comment
jonkafton
left a comment
There was a problem hiding this comment.
Interested that passing options to the second argument as in the legacy router.push() https://nextjs.org/docs/pages/api-reference/functions/use-router#routerpush cleared the path. That eluded me in any case - glad it's fixed!
We have a followup PR that needed the new course-search-utils version to fix the close button positioning #1617
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Fixes https://github.com/mitodl/hq/issues/5472
The issue was closed a little early
Description (What does it do?)
Bumps course-search-utils to latest version
How can this be tested?