search defaults fix #1681
Merged
search defaults fix #1681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeglova
force-pushed
the
ab/search-defaults-fix
branch
from
370bfb5 to
1ae0593
Compare
shanbady
approved these changes
Oct 15, 2024
Contributor
shanbady
left a comment
shanbady
left a comment
There was a problem hiding this comment.
Looks good. works as intended
abeglova
force-pushed
the
ab/search-defaults-fix
branch
from
1ae0593 to
eca0dcb
Compare
Closed
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
closes https://github.com/mitodl/hq/issues/5706
Description (What does it do?)
#1590 was supposed to make the search setting settable from the environment. This worked for the backend but not the frontend. This creates a small api page that shares the defaults with the frontend
How can this be tested?
Go to http://open.odl.local:8062/search/ . Everything should work as expected as both an admin user and non-logged in user.
Log in as an admin. You should be able to manipulate the admin search settings.
Set some of the setting from your .env variable. For example
DEFAULT_SEARCH_SLOP=2
DEFAULT_SEARCH_MODE=best_fields
Restart docker. The defaults in the admin facet should be set to the settings from your .env file