Skip to content

Conversation

@abeglova
Copy link
Contributor

@abeglova abeglova commented Sep 20, 2024

What are the relevant tickets?

Description (What does it do?)

This PR makes default admin search setting settable as environment variables. I also sets search_mode= phrase slop=6 max_incompleteness_penalty=90 as the default

Screenshots (if appropriate):

  • Desktop screenshots
  • Mobile width screenshots

How can this be tested?

  • Verify that the search page works
  • Verify that as a logged in user, you can manipulate the admin settings
  • Verify that when you set DEFAULT_SEARCH_MODE, DEFAULT_SEARCH_SLOP, DEFAULT_SEARCH_STALENESS_PENALTY, DEFAULT_SEARCH_MINIMUM_SCORE_CUTOFF or DEFAULT_SEARCH_MAX_INCOMPLETENESS_PENALTY, the default is changed in the ui for admin users

@abeglova abeglova marked this pull request as ready for review September 20, 2024 22:47
@mbertrand mbertrand self-assigned this Sep 23, 2024
Copy link
Member

@mbertrand mbertrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@abeglova abeglova force-pushed the ab/search-environment-vars branch from 889d75f to 14ebf92 Compare September 23, 2024 16:03
@abeglova abeglova merged commit 9e9fc07 into main Sep 23, 2024
@odlbot odlbot mentioned this pull request Sep 23, 2024
3 tasks
jonkafton added a commit that referenced this pull request Sep 25, 2024
* Codespace opensearch service fix (#1582)

* testing codespace fix

* testing fix

* Release 0.19.2

* Fix extract_openedx_data and backpopulate_mit_edx_data commands to work with course/program datafiles (#1587)

* follow/unfollow popover (#1589)

* adding success variant

* adding working version

* adding working version

* fixing text and adding margin to buttons

* lint fixes

* lint fix

* fixing test cases

* closing popup before posting data

* removing redundancy

* removing redundancy

* removing empty test

* updating styles

* updating styles

* changes to match design

* changes to match design

* Make search mode defaults settable env variables (#1590)

* Release date for 0.19.2

* Release 0.19.3

* Release date for 0.19.3

* Pace and format fields for learning resources (#1588)

* Migrate search settings #5527

---------

Co-authored-by: Shankar Ambady <shanbady@gmail.com>
Co-authored-by: Doof <mitx-devops@mit.edu>
Co-authored-by: Matt Bertrand <mrbertrand@gmail.com>
Co-authored-by: Anastasia Beglova <abeglova@mit.edu>
@abeglova abeglova mentioned this pull request Oct 11, 2024
@rhysyngsun rhysyngsun deleted the ab/search-environment-vars branch February 7, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants