-
Notifications
You must be signed in to change notification settings - Fork 3
add new learning resource drawer layout #1711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
866d372 to
a16fc3b
Compare
f38a1e3 to
9f6e1d4
Compare
856b183 to
fe3a816
Compare
abeglova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <InfoSection resource={resource} /> | ||
| </LeftContainer> | ||
| <RightContainer> | ||
| <CallToActionSection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds a call to action for all resource types. The button does not go anywhere for video playlists and learning paths since url is null for those resources and getCallToActionUrl only has special logic for podcasts. http://api.open.odl.local:8063/api/v1/learning_resources_search/?resource_type=video_playlist . You can add special logic to construct the correct url based on the channel_id for the video playlist. I'm not sure if we are supposed to have learning paths in prod. There is currently one in the production search but I think that it might not be supposed to be visible
|
Note to self: fix alignment of bookmark buttons when "on platform" section is not present. |
61e8703 to
542a661
Compare
|
@abeglova Thanks for your review, this is ready for another look. The mobile video issue actually had to do with the description on that particular video causing the description field to overflow the flex parent because of the |
abeglova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
| <ActionButton | ||
| style={closeSx} | ||
| variant="text" | ||
| size="medium" | ||
| onClick={setOpen.off} | ||
| aria-label="Close" | ||
| > | ||
| <CloseIcon /> | ||
| </ActionButton> | ||
| {!hideCloseButton && ( | ||
| <CloseButton | ||
| variant="text" | ||
| size="medium" | ||
| onClick={setOpen.off} | ||
| aria-label="Close" | ||
| > | ||
| <CloseIcon /> | ||
| </CloseButton> | ||
| )} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only instance we have of RoutedDrawer sets hideCloseButton={true}... Can we skip changing the close button style here?
f0036c9 to
9c23f91
Compare
|
@gumaerc I checked out the posthog stuff. Worked well. |
…fo section values
…playlist thumbnail
…n't wrap in the worst case scenario
3fb43d2 to
c42b84a
Compare


What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/5819
Description (What does it do?)
This PR is a first pass at implementing the new wider learning resource drawer design. The structure and styles have been altered to match what's included in the design, minus the out of scope items listed in the issue. As part of this, the dropdown UI for selecting runs that changes the information section has been removed. Instead, all possible values across all runs are shown in a pipe separated list.
Screenshots (if appropriate):
How can this be tested?
mit-learnon this branch