-
Notifications
You must be signed in to change notification settings - Fork 3
Release 0.25.0 #1791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Release 0.25.0 #1791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make only title the anchor * only use title as link * add resourceType label to resource cards * dont clip title outline * tweak two tests * remove absolute positioning from Card * remove absolute positioning from ListCard etc * Make link forwarding opt-in; LR cards articles * remove posthog console.log * add a comment
* new width and title section * move close button into drawer content * use flex instead of absolute positioning for close button * reorganize top level layout and remove lorem ipsum * info section styles * call to action styling * simply flip flex direction at medium for now on drawer content * switch out certificate icon * use new separator style on instructors in info section * remove extraneous container gap * mobile styling * add back bookmark and learning path buttons * fix certificate display and hide info item icons on mobile * align info item labels center * fix tests, add new tests * move title container outside of content container so that when you scroll and it stays on top the box shadow doesn't leak outside the padding boundary * convert LearningResourceExpanded styled element to object notation because it's cleaner and prevents errors about incorrect CSS rule names * remove remaining traces of run selection dropdown logic, display unique list of values based on all runs for levels, languages and instructors * wrap embedly card in a container to restrict its width in cta section * remove extraneous extra top padding * move start date above price * use padding for separator instead of spaces * updated boxShadow value for cta section * fix rebase issue with closeDrawer parameter * refactor getCallToActionText * prevent wrapping mid-item * fix wrapping in Chrome * re-add hideCloseButton argument on LearningResourceDrawer's RoutedDrawer component that got removed during rebase * default CTA for non-OCW courses should be "Learn More" * adjust description line height to 1.2rem * fix info items alignment * further fix icon alignment * remove incorrectly placed line height directive and set row-gap on info section values * load the playlist URL onto the playlist learning resource in ETL * set the data during the transform step instead, and also pull in the playlist thumbnail * fix alignment of list buttons when platform is not present * fix description pushing call to action off the drawer * grow the left side * fix test * fix tests * mobile style fixes * fix key prop issue * fix drawer max width * fix info item word wrap * make tablet view a little better * refine info section value items text wrapping strategy * add a zero width space to the end of the separator * fix tests * wrap price / certificate display on mobile * add another comment explaining the separator * also reduce font size of the certificate section on mobile so it doesn't wrap in the worst case scenario * put the new drawer behind a posthog feature flag * remove debug code * fix tests
* Upgrade to Next.js v15. Page params are now async * Upgrade @mui/material-nextjs for Next.js v15 * Suspense boundaries needed around carousels (useSearchParams() should be wrapped error) * Upgrade @mui dependencies * CKEditor display not needed and causing error * Update test * Next peer dependency and relax version range. MUI V15 pointer.
* Use Next.js Image component in the resource drawer * Differentiate NavItem props from config type * Replace about page image * Next.js images for channel page logos. Unit image config in Logo component * Remove NavDrawer image paths (not used). Fix Storybook page * Upgrade to Next.js v15. Page params are now async * Upgrade @mui/material-nextjs for Next.js v15 * Utility for CSS background image-set() strings. Apply to homepage personalize section * Pass background static import src to banner * Use Logo component for unit cards * Suspense boundaries needed around carousels (useSearchParams() should be wrapped error) * Type fix * Display YouTube videos with simple iframe * 16:9 aspect ratio for videos * Revert "Suspense boundaries needed around carousels (useSearchParams() should be wrapped error)" This reverts commit b96fb61. * Revert "Upgrade @mui/material-nextjs for Next.js v15" This reverts commit 18fee78. * Revert "Upgrade to Next.js v15. Page params are now async" This reverts commit 20f0f05. * Update test for unit logo * Add Nextjs dependency in ol-utilities * Remove comments * Remove unnecessary truthy check * Separate Unit/Platform Logo * Move to peer dependency * Bckground src set for topic banner * Background src set on other banner backgrounds * Remove redundant display breakpoints * Apply changes to LearningResourceExpandedV2 * Update test
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
983636f to
bf73546
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nathan Levesque
Matt Bertrand
renovate[bot]
Jon Kafton
Carey P Gumaer
Chris Chudzicki