Skip to content

Conversation

@ChristopherChudzicki
Copy link
Contributor

What are the relevant tickets?

Description (What does it do?)

Most of https://github.com/mitodl/hq/issues/5427 was handled in #1545. This fixes the final placeholder color—multiline inputs, aka textarea.

Screenshots (if appropriate):

This branch:

Screenshot 2024-10-18 at 3 33 17 PM

vs RC

Screenshot 2024-10-18 at 3 34 02 PM

How can this be tested?

View the userlist creation modal. The inputs should all have same color placeholder text.

@ChristopherChudzicki ChristopherChudzicki added the Needs Review An open Pull Request that is ready for review label Oct 18, 2024
@ChristopherChudzicki ChristopherChudzicki marked this pull request as ready for review October 18, 2024 19:36
@mbertrand mbertrand self-assigned this Oct 21, 2024
Copy link
Member

@mbertrand mbertrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mbertrand mbertrand added Waiting on author and removed Needs Review An open Pull Request that is ready for review labels Oct 21, 2024
@ChristopherChudzicki ChristopherChudzicki merged commit 5d1b628 into main Oct 21, 2024
11 checks passed
This was referenced Oct 21, 2024
@rhysyngsun rhysyngsun deleted the cc/placeholder-color branch February 7, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants