Skip to content

Conversation

@jonkafton
Copy link
Contributor

@jonkafton jonkafton commented Oct 29, 2024

What are the relevant tickets?

N/A

Description (What does it do?)

Issue in production where the Hero image causes overflow to the right of its container causing the page to be horizontally scrollable. To replicate, reduce your screen width to <1365px and scroll left:

image



By design the image is translated right by 48px so is cropped right on the page. With this fix:

image



We could add an overflow: hidden to its container, though the issue is that the image scales and at larger screen widths we want to see the whole image, otherwise it looks like this:

image



This fix add a media breakpoint so that the image displays in full at larger widths, but has overflow hidden where it would interfere with the page margins.

Open to a better solution with the css, or an update to the design where the image is not translated right (not sure how intentional this was), which looks like:

image

Screenshots (if appropriate):

  • Desktop screenshots
  • Mobile width screenshots

How can this be tested?

The homepage should not be scrollable at all screen widths and the hero image should display correctly.

@jonkafton jonkafton added the Needs Review An open Pull Request that is ready for review label Oct 29, 2024
@shanbady shanbady self-requested a review October 30, 2024 13:45
@shanbady shanbady self-assigned this Oct 30, 2024
Copy link
Contributor

@shanbady shanbady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@shanbady shanbady added Waiting on author and removed Needs Review An open Pull Request that is ready for review labels Oct 30, 2024
@jonkafton jonkafton merged commit c5e50c4 into main Oct 31, 2024
11 checks passed
@jonkafton jonkafton deleted the jk/fix-hero-image-width branch October 31, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants