Fix DST issue #1788
Merged
Fix DST issue #1788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhysyngsun
requested changes
Nov 4, 2024
news_events/etl/utils.py
Outdated
| datetime: The parsed datetime object | ||
| """ | ||
| dt_utc = None | ||
| log.error(text_date) |
rhysyngsun
added
Waiting on author
and removed
Needs Review
mbertrand
added
Needs Review
This was referenced Nov 5, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
N/A
Description (What does it do?)
Tries to parse the date and time together instead of individually, which was causing the time range DST offset if any to be applied based on the current ddate.
Screenshots (if appropriate):
How can this be tested?
All tests should pass