Fixes to address scim-for-keycloak weirdness #1789
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Part of https://github.com/mitodl/hq/issues/5561
Description (What does it do?)
This makes some tweaks to the SCIM adaptor to handle some weird data we're getting from the scim-for-keycloak plugin I didn't previously notice:
emailOptIn.displayNameto usingfullName.displayNameworked on full data syncs, but if you only updated your full name on the account page it wasn't triggering a SCIM PATCH request over to Learn. There must be some special handling of it in the plugin, despite the appearance in the admin UI that you could usedisplayNamefor a custom user property.How can this be tested?
displayNameand adding a new attribute namedfullNamethat uses thefullNamecustom attribute. All other settings can be left as the default.You should be able to go through the following flows:
/realms/olapps/account/on Keycloak, this redirects to the login pages and avoids us exercising the social auth code on Learn that can obfuscate whether SCIM worked correctly or not./adminon the Learn API and verify the user has been created and has the correct name and theemail_optinsetting is set to true/yes./realms/olapps/account/on Keycloak and login as an existing user