Skip to content

Conversation

@jonkafton
Copy link
Contributor

@jonkafton jonkafton commented Oct 21, 2025

What are the relevant tickets?

Closes: https://github.com/mitodl/hq/issues/8976

Description (What does it do?)

  • The "MIT Learn" header logo links to /dashboard when a user is logged in
  • A button link to the Dashboard is shown on desktop when a user is logged in and not in a dashboard page.
  • The header mobile breakpoint is increased to 900px to accommodate the button and to fix a layout bug in Prod in which space is limited even without the additional button.

Screenshots (if appropriate):

image

Layout bug at 600px to ~700px:
Before:
image

After:
image

How can this be tested?

When not logged in:

  • Check that MIT Learn header link points to the homepage, /.

When logged in:

  • Check that MIT Learn header link points to your dashboard, /dashboard.
    • When not on a dashboard page:
      • Check that the new dashboard button shows in the header (desktop only).
    • When on a dashboard page:
      • Check that the dashboard button does not show.

Additional Context

@jonkafton jonkafton marked this pull request as draft October 21, 2025 21:38
@jonkafton jonkafton added the Needs Review An open Pull Request that is ready for review label Oct 22, 2025
@jonkafton jonkafton marked this pull request as ready for review October 22, 2025 13:35
@abeglova abeglova self-assigned this Oct 23, 2025
Copy link
Contributor

@abeglova abeglova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the stray logging statement

return null
}

console.log("pathname", pathname)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to remove console.log here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised that this did not break the tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add an ESLint rule. Problem is we can't build with lint errors, so catch 22 for debugging production builds.

@jonkafton jonkafton merged commit ba0e5e1 into main Oct 23, 2025
13 checks passed
@jonkafton jonkafton deleted the jk/8976-dashboard-header-links branch October 23, 2025 18:54
@odlbot odlbot mentioned this pull request Oct 27, 2025
16 tasks
@jonkafton jonkafton removed the Needs Review An open Pull Request that is ready for review label Oct 27, 2025
@odlbot odlbot mentioned this pull request Oct 27, 2025
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants