Fixes top margin at <md breakpoint #2636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frontends/main/src/app/styled.tsx
Outdated
| [theme.breakpoints.down("sm")]: { | ||
| [theme.breakpoints.down("md")]: { | ||
| marginTop: "60px", | ||
| height: "calc(100vh - 60px)", |
Contributor
There was a problem hiding this comment.
Could you switch this and the 72px above to theme.custom.dimensions.headerHeightSm, theme.custom.dimensions.headerHeight. (Maybe smoot should have a theme.custom.dimensions.headerHeightMd.)
I'd also do a find-all for a few other places that need to be changed. One is the left-side nav bar.
ChristopherChudzicki
requested changes
Oct 27, 2025
Contributor
ChristopherChudzicki
left a comment
ChristopherChudzicki
left a comment
There was a problem hiding this comment.
A few other places need to be changed and it would be good to use the constants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
N/A
Description (What does it do?)
Fixes issue with extra top margin at screen width >600px and <900px.
Screenshots (if appropriate):
Before:
After:
How can this be tested?
Size your browser window width to somewhere between 600px and 900px. Check that there is no gap between the header and the main content background. The issue on all pages, though less noticeable on the dashboard pages as they have no background <900px.
Additional Context
Introduced in #2620, which increased the header layout responsive breakpoint from 600px to 900px, but did not apply the same to margin calculation on the page wrapper top margin.