show resource_category in channel pages#3264
Conversation
OpenAPI ChangesNo changes detected Unexpected changes? Ensure your branch is up-to-date with |
There was a problem hiding this comment.
Pull request overview
Adds support for displaying the resource_category facet on Channel pages (Topic/Department/Unit), aligned with the existing behavior that the facet only appears when resource_type_group=learning_material.
Changes:
- Enable
resource_categoryas an allowed facet for Topic/Department/Unit channel searches. - Add a Channel page test asserting
Resource Categoryis hidden by default and shown whenresource_type_group=learning_material.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| frontends/main/src/app-pages/ChannelPage/searchRequests.ts | Adds resource_category to the per-channel-type facet allowlist so it can render when present in the facet manifest. |
| frontends/main/src/app-pages/ChannelPage/ChannelSearch.test.tsx | Adds a regression test for conditional visibility of the Resource Category facet based on resource_type_group. |
| const FACETS_BY_CHANNEL_TYPE: Record<ChannelTypeEnum, string[]> = { | ||
| [ChannelTypeEnum.Topic]: [ | ||
| "free", | ||
| "resource_category", | ||
| "resource_type", |
There was a problem hiding this comment.
resource_category is now enabled as a facet for Topic/Department/Unit channels, but the added test only exercises the Topic case. Consider adding coverage for Department and Unit as well (e.g., test.each over channel types) to ensure the facet shows/hides correctly across all channel page variants.
There was a problem hiding this comment.
agree with adding the test for all channel types
shanbady
left a comment
shanbady
left a comment
There was a problem hiding this comment.
I agree with copilot's suggestion change (also consider adding the non-channel search page if there is no existing test for that)
| const FACETS_BY_CHANNEL_TYPE: Record<ChannelTypeEnum, string[]> = { | ||
| [ChannelTypeEnum.Topic]: [ | ||
| "free", | ||
| "resource_category", | ||
| "resource_type", |
There was a problem hiding this comment.
agree with adding the test for all channel types
|
There is an existing test for non-channel search |
abeglova
force-pushed
the
ab/show-resource-category-facet-for-channel
branch
from
b3f0a02 to
8a67924
Compare
What are the relevant tickets?
https://github.com/mitodl/hq/issues/11064
Description (What does it do?)
This pr updates the channel search to show the resource_category facet in channel pages
Screenshots (if appropriate):
How can this be tested?
If you don't have learning materials attached to a unit with a channel run
docker-compose run web ./manage.py manage.py backpopulate_youtube_dataGo to
http://open.odl.local:8062/c/unit/ocw?resource_type_group=learning_material
and verify that you see the resource category facet
Switch to the "course" and "all" tabs and verify that you do not see the resource category facet