fix: remove h5 font weight override#3272
Merged
daniellefrappier18 merged 4 commits intoMay 5, 2026
Merged
Conversation
OpenAPI ChangesNo changes detected Unexpected changes? Ensure your branch is up-to-date with |
daniellefrappier18
added
the
Needs Review
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a mobile-only fontWeight override on the UAI Announcement Card title, intending to rely on the updated h5 typography coming from @mitodl/smoot-design instead of a local override.
Changes:
- Removed the
fontWeightBoldoverride from thesmbreakpoint styles for the card title.
daniellefrappier18
deleted the
daniellef/10977-remove-h5-font-weight-override
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Fixes https://github.com/mitodl/hq/issues/10977
Description (What does it do?)
Removes a local
fontWeightoverride that was added to match Figma's h5 design. Now that the h5 typography definition in smoot-design has been updated to usefontWeight: 700(Neue Haas Grotesk 65 Bold), the override is redundant.Screenshots (if appropriate):
AFTER (override removed — inheriting h5 from current smoot-design): The title will render at 700 (bold)
automatically — matching the "before" screenshot — without the local override.
How can this be tested?
Using the browser's dev tools inspector, verify that the h5 element reflects a font-weight of 700.
Additional Context