Skip to content

fix: remove the top border when there is only single item and removed the current episode from the more episode list#3299

Merged
ahtesham-quraish merged 2 commits into
mainfrom
ahtesham/podcast-imp-branch
May 6, 2026
Merged

fix: remove the top border when there is only single item and removed the current episode from the more episode list#3299
ahtesham-quraish merged 2 commits into
mainfrom
ahtesham/podcast-imp-branch

Conversation

@ahtesham-quraish
Copy link
Copy Markdown
Contributor

@ahtesham-quraish ahtesham-quraish commented May 6, 2026

What are the relevant tickets?

n/a

Description (What does it do?)

  • There was edge case that if there is only single episode then the top border was rendering which should not so this is about removing the top border in case single item
  • one more change in this PR that the current episode should not be the part of More from <podcast> which was previously part of this list so I removed it from that more episode list.

Screenshots (if appropriate):

Before
image

After
image

How can this be tested?

if you don't have playlist data locally then in frontend env file you should add the following variable NEXT_PUBLIC_MITOL_API_BASE_URL="https://api.rc.learn.mit.edu" it will connect with RC learn backend
then we need to enable the flag which is podcast-detail-page and then visit the following url http://open.odl.local:8062/podcast/128673/podcast_episode/128674

Additional Context

Copilot AI review requested due to automatic review settings May 6, 2026 08:12
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

OpenAPI Changes

No changes detected

View full changelog

Unexpected changes? Ensure your branch is up-to-date with main (consider rebasing).

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a UI edge case in the podcast episode list styling: when there’s only a single episode in the “episode page” variant, the row was incorrectly rendering a top divider/border. The change updates the EpisodeRow styled component to ensure a single-item list renders only the bottom divider.

Changes:

  • Add a more-specific CSS selector (:first-of-type:last-child) for the episode-page variant to override the existing :last-child rule when the list has exactly one item.
  • Ensure the single episode retains the bottom divider while keeping the top divider removed.

Copy link
Copy Markdown
Contributor

@zamanafzal zamanafzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zamanafzal zamanafzal self-assigned this May 6, 2026
@zamanafzal zamanafzal added the Needs Review An open Pull Request that is ready for review label May 6, 2026
@ahtesham-quraish ahtesham-quraish changed the title fix: remove the top border when there is only single item fix: remove the top border when there is only single item and removed the current episode from the more episode list May 6, 2026
@ahtesham-quraish ahtesham-quraish force-pushed the ahtesham/podcast-imp-branch branch from 05a560c to 67c1693 Compare May 6, 2026 08:41
@ahtesham-quraish ahtesham-quraish force-pushed the ahtesham/podcast-imp-branch branch from 67c1693 to 1852662 Compare May 6, 2026 08:59
@ahtesham-quraish ahtesham-quraish merged commit 244a412 into main May 6, 2026
13 of 14 checks passed
@ahtesham-quraish ahtesham-quraish deleted the ahtesham/podcast-imp-branch branch May 6, 2026 09:09
This was referenced May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review An open Pull Request that is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants