fix: remove the top border when there is only single item and removed the current episode from the more episode list#3299
Merged
Conversation
OpenAPI ChangesNo changes detected Unexpected changes? Ensure your branch is up-to-date with |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a UI edge case in the podcast episode list styling: when there’s only a single episode in the “episode page” variant, the row was incorrectly rendering a top divider/border. The change updates the EpisodeRow styled component to ensure a single-item list renders only the bottom divider.
Changes:
- Add a more-specific CSS selector (
:first-of-type:last-child) for the episode-page variant to override the existing:last-childrule when the list has exactly one item. - Ensure the single episode retains the bottom divider while keeping the top divider removed.
05a560c to
67c1693
Compare
67c1693 to
1852662
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
n/a
Description (What does it do?)
More from <podcast>which was previously part of this list so I removed it from that more episode list.Screenshots (if appropriate):
Before

After

How can this be tested?
if you don't have playlist data locally then in frontend env file you should add the following variable
NEXT_PUBLIC_MITOL_API_BASE_URL="https://api.rc.learn.mit.edu"it will connect with RC learn backendthen we need to enable the flag which is
podcast-detail-pageand then visit the following urlhttp://open.odl.local:8062/podcast/128673/podcast_episode/128674Additional Context