feat: show duplicate emails and stats summary in B2B seat assignment modal by daniellefrappier18 · Pull Request #3509 · mitodl/mit-learn

daniellefrappier18 · 2026-06-22T17:33:26Z

What are the relevant tickets?

Description (What does it do?)

Adds duplicateEmails: string[] prop to AssignSeatsConfirmModal — duplicate addresses are now listed individually in the review step, not just counted
Adds stats cards to the confirm step (invitations, seats remaining after sending) and the over-capacity state (imported, seats available, over the limit)
Updates Dialog to accept React.ReactNode for the title prop, enabling icon badges alongside text in dialog headers
Updates extractEmailsFromCsvRows and parseEmailsForSubmit in ol-utilities to return duplicateEmails[] alongside duplicateCount

Screen Recording (if appropriate):

Desktop screenshots
Mobile width screenshots

AssignSeats.mov

Using NVDA

assign_seats_nvda.mp4

How can this be tested?

Confirm step (no issues):

Upload a CSV with all valid, unique emails within seat capacity.
Confirm the stats card shows the correct invitation count and seats remaining after sending.
Click "Send N Invitations" — confirm the modal closes after submission.

Review step (duplicates):

Upload a CSV with duplicate emails.
Confirm the review step lists the duplicate addresses individually (not just a count).
Advance to confirm and send — confirm only deduplicated emails are submitted.

Review step (all invalid):

Upload a CSV with only invalid emails.
Confirm that an inline error appears and no dialog opens

Review step (invalid + duplicates):

Upload a CSV with both invalid and duplicate emails.
Confirm both categories render correctly in the review step.

Over-capacity (CSV):

Upload a CSV where valid email count exceeds available seats.
Confirm the stats card shows Imported, Seats available, and Over the limit with correct values.

Over-capacity (manual entry):

Add valid email count exceeds available seats.
Confirm that an inline error displays and the Assign Seats button is disabled

Additional Context

github-actions · 2026-06-22T17:34:54Z

OpenAPI Changes

No changes detected

View full changelog

Unexpected changes? Ensure your branch is up-to-date with main (consider rebasing).

…dialog

- Deduplicate duplicateEmails for 3+ occurrences of the same address - Drop redundant duplicateCount prop; derive from duplicateEmails.length - Show "Sending…" on Send button while async confirm is in flight - Fix pre-existing test failures from ambiguous queries and timing

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

dsubak · 2026-06-24T14:46:03Z

+      {overCapacity && (
+        <Alert severity="error">
+          You entered {validCount} {pluralize("email", validCount)}, but only{" "}
+          {availableSeats} unassigned {pluralize("seat", availableSeats)} are


I think if availableSeats is 1, it'll end up reading "but only 1 available seat are available.`

good catch. All set now

dsubak · 2026-06-24T17:59:00Z

  )
 }

+const copyToClipboard = (text: string) => {


This might just be a me/my browser problem, but attempting to copy duplicate emails when uploading a CSV w/ dupes doesn't seem to actually copy to the clipboard. It does switch the text to Copied!, but when I try and paste it looks like it just has whatever I previously copied.

That said, I also get some very unrelated looking errors, so I'd say if this isn't reproducible and everything looks shipshape for others, feel free to ignore this!

Nope, not your browser - you found a real bug. But should be resolved now

Looking good on my end! Thanks!

dsubak

Tested all the manual cases, seems pretty good!

I only noticed one hiccup with the clipboard copying, but as noted in the comment, I can't even be sure if this is my browser or not so feel free to ignore it if it can't be reproduced.

ChristopherChudzicki · 2026-06-24T19:12:28Z

+    let resolve!: () => void
+    const promise = new Promise<void>((res) => {
+      resolve = res
+    })


BTW, Promise.withResolvers exists now

const { promise, resolve, reject } = Promise.withResolvers();

Promise.withResolvers() is cleaner and the ! assertion was a lie TypeScript was happy to accept.

redesign AssignSeatsConfirmModal flow

25beeea

daniellefrappier18 added 4 commits June 22, 2026 13:48

format fix

1ade395

screen reader coverage for AssignSeatsConfirmModal dialogs

2ac74c5

prevent NVDA double-reading in AssignSeatsConfirmModal over-capacity …

e27e881

…dialog

daniellefrappier18 marked this pull request as ready for review June 23, 2026 16:57

Copilot AI review requested due to automatic review settings June 23, 2026 16:57

Copilot started reviewing on behalf of daniellefrappier18 June 23, 2026 16:57 View session

This comment was marked as outdated.

Sign in to view

daniellefrappier18 added 2 commits June 23, 2026 13:46

more accessibility fixes for AssignSeatConfirmModal

38eda3b

format fix

18fa957

daniellefrappier18 requested a review from Copilot June 23, 2026 18:02

Copilot started reviewing on behalf of daniellefrappier18 June 23, 2026 18:02 View session

Copilot AI reviewed Jun 23, 2026

View reviewed changes

Comment thread frontends/main/src/app-pages/ContractAdminPage/AssignSeatsConfirmModal.tsx Outdated

Comment thread frontends/main/src/app-pages/ContractAdminPage/AssignSeatsConfirmModal.tsx Outdated

Comment thread frontends/main/src/app-pages/ContractAdminPage/AssignSeatsConfirmModal.tsx Outdated

daniellefrappier18 added 3 commits June 23, 2026 15:29

Clear email input after seat assignment and on CSV load

28482b3

Improve AssignSeatsSection validation UX and screen reader support

26debb0

Fix count badge visibility and duplicate list keys in ContractAdminPage

67625c6

dsubak reviewed Jun 24, 2026

View reviewed changes

dsubak approved these changes Jun 24, 2026

View reviewed changes

daniellefrappier18 added 2 commits June 24, 2026 14:23

Fix clipboard copy in AssignSeatsConfirmModal and add test

fc1de7c

Fix subject-verb agreement for singular available seat count

e07d1b1

ChristopherChudzicki reviewed Jun 24, 2026

View reviewed changes

use Promise.withResolvers() for deferred promise in test

552df5f

daniellefrappier18 merged commit 3ea5436 into main Jun 25, 2026
13 checks passed

daniellefrappier18 deleted the daniellef/b2b-admin-dialogs branch June 25, 2026 13:08

This was referenced Jun 25, 2026

Release 0.71.15 #3527

Closed

Release 0.71.16 #3531

Closed

Release 0.72.1 #3535

Merged

Uh oh!

Conversation

daniellefrappier18 commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What are the relevant tickets?

Description (What does it do?)

Screen Recording (if appropriate):

How can this be tested?

Additional Context

Uh oh!

github-actions Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

OpenAPI Changes

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dsubak Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

daniellefrappier18 Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

dsubak Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

daniellefrappier18 Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

dsubak Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

dsubak left a comment

Choose a reason for hiding this comment

Uh oh!

ChristopherChudzicki Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daniellefrappier18 Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

daniellefrappier18 commented Jun 22, 2026 •

edited

Loading

github-actions Bot commented Jun 22, 2026 •

edited

Loading

ChristopherChudzicki Jun 24, 2026 •

edited

Loading