Skip to content

Remove unused newrelic#3285

Merged
rhysyngsun merged 1 commit intomainfrom
nl/remove-newrelic
Feb 9, 2026
Merged

Remove unused newrelic#3285
rhysyngsun merged 1 commit intomainfrom
nl/remove-newrelic

Conversation

@rhysyngsun
Copy link
Collaborator

What are the relevant tickets?

N/A

Description (What does it do?)

Removes the newrelic dependency as we haven't used it in a while and it's now failing to install.

How can this be tested?

Tests should pass

@github-actions
Copy link

github-actions bot commented Feb 9, 2026

OpenAPI Changes

Show/hide ## Changes for v0.yaml:
## Changes for v0.yaml:


## Changes for v1.yaml:


## Changes for v2.yaml:


Unexpected changes? Ensure your branch is up-to-date with main (consider rebasing).

mitol-django-payment-gateway = "2023.12.19"
mitol-django-scim = ">=2025.5.23"
newrelic = "^11.4.0"
opentelemetry-api = ">=1.31.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The newrelic package is removed, but the Procfile still uses the newrelic-admin command, which will cause application startup to fail.
Severity: CRITICAL

Suggested Fix

Remove the newrelic-admin run-program command from the web, worker, and extra_worker process definitions in the Procfile since the newrelic package that provides it is being removed.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: pyproject.toml#L56

Potential issue: The pull request removes the `newrelic` package dependency from
`pyproject.toml`. However, the `Procfile` was not updated and still contains startup
commands for the `web`, `worker`, and `extra_worker` processes that rely on
`newrelic-admin`, a command-line tool from that package. After this change is deployed,
the `newrelic-admin` command will no longer exist. This will cause all application
processes to fail to start with a 'command not found' error, preventing the application
from running entirely.

Did we get this right? 👍 / 👎 to inform future reviews.

@rhysyngsun rhysyngsun merged commit 85bdfb8 into main Feb 9, 2026
10 checks passed
@rhysyngsun rhysyngsun deleted the nl/remove-newrelic branch February 9, 2026 17:54
@odlbot odlbot mentioned this pull request Feb 10, 2026
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants