Merged
Conversation
57e2897 to
fcd49cf
Compare
OpenAPI ChangesShow/hide ## Changes for v0.yaml:Unexpected changes? Ensure your branch is up-to-date with |
cp-at-mit
approved these changes
Feb 9, 2026
| mitol-django-payment-gateway = "2023.12.19" | ||
| mitol-django-scim = ">=2025.5.23" | ||
| newrelic = "^11.4.0" | ||
| opentelemetry-api = ">=1.31.0" |
There was a problem hiding this comment.
Bug: The newrelic package is removed, but the Procfile still uses the newrelic-admin command, which will cause application startup to fail.
Severity: CRITICAL
Suggested Fix
Remove the newrelic-admin run-program command from the web, worker, and extra_worker process definitions in the Procfile since the newrelic package that provides it is being removed.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: pyproject.toml#L56
Potential issue: The pull request removes the `newrelic` package dependency from
`pyproject.toml`. However, the `Procfile` was not updated and still contains startup
commands for the `web`, `worker`, and `extra_worker` processes that rely on
`newrelic-admin`, a command-line tool from that package. After this change is deployed,
the `newrelic-admin` command will no longer exist. This will cause all application
processes to fail to start with a 'command not found' error, preventing the application
from running entirely.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
N/A
Description (What does it do?)
Removes the newrelic dependency as we haven't used it in a while and it's now failing to install.
How can this be tested?
Tests should pass