fix: correct condition in tfact_certificate to use max_activity_on#2210
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an incremental build failure in the tfact_certificate dbt model by correcting the incremental watermark column reference to match the incremental_watermarks CTE, resolving a Trino COLUMN_NOT_FOUND error.
Changes:
- Replace the incorrect
w.max_created_onreference withw.max_activity_onin the incremental filter fortfact_certificate.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
https://pipelines.odl.mit.edu/runs/05a8f4e8-33b5-4977-a9b1-41bc5057038d
Description (What does it do?)
fixes the dbt error
How can this be tested?
dbt build --select tfact_certificate
Additional Context