Change the frontend hash URL for UE; fix deprecated CI actions and pin to commits #398
Conversation
it's being put at /, doof thinks it's at /static/hash.txt
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @jkachel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request changes the hash URLs for the unified-ecommerce and unified-ecommerce-frontend repositories in the repos_info.json file. Specifically, it updates the rc_hash_url for unified-ecommerce from https://api-pay-rc.ol.mit.edu/static/hash.txt to https://api-pay-qa.ol.mit.edu/static/hash.txt. For unified-ecommerce-frontend, it removes /static from all three hash URLs (ci_hash_url, rc_hash_url, and prod_hash_url). The intent is to ensure that the doof tool looks in the correct location for the UE frontend hash.
Highlights
- Hash URL Update: The
rc_hash_urlfor theunified-ecommercerepo was updated to point to theqaenvironment. - Frontend Hash URL Correction: The
/staticpath segment was removed from theci_hash_url,rc_hash_url, andprod_hash_urlfor theunified-ecommerce-frontendrepository.
Changelog
- repos_info.json
- Updated
rc_hash_urlforunified-ecommercefromhttps://api-pay-rc.ol.mit.edu/static/hash.txttohttps://api-pay-qa.ol.mit.edu/static/hash.txt(line 194). - Removed
/staticfromci_hash_url(line 204),rc_hash_url(line 205), andprod_hash_url(line 206) forunified-ecommerce-frontend.
- Updated
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A path was wrong, a file misplaced,
The frontend hash, a hurried pace.
But now it's fixed, the URL's right,
Doof will find it, day and night.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request modifies the hash URLs in repos_info.json for the unified-ecommerce and unified-ecommerce-frontend repositories. The change ensures that the doof bot looks in the correct location for the frontend hash. The changes appear correct and align with the stated objective.
Merge Readiness
The pull request appears to be ready for merging. The changes are straightforward and address the specified issue. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.
| "ci_hash_url": "https://api-pay-ci.ol.mit.edu/static/hash.txt", | ||
| "rc_hash_url": "https://api-pay-rc.ol.mit.edu/static/hash.txt", | ||
| "rc_hash_url": "https://api-pay-qa.ol.mit.edu/static/hash.txt", |
There was a problem hiding this comment.
The change from api-pay-rc.ol.mit.edu to api-pay-qa.ol.mit.edu for the rc_hash_url seems correct, aligning with the QA environment. Double-check that this is the intended environment for release candidate hash URLs.
| "ci_hash_url": "https://pay-ci.ol.mit.edu/hash.txt", | ||
| "rc_hash_url": "https://pay-qa.ol.mit.edu/hash.txt", | ||
| "prod_hash_url": "https://pay.ol.mit.edu/hash.txt", |
There was a problem hiding this comment.
The removal of /static/ from the ci_hash_url and rc_hash_url for the frontend repository seems correct, aligning with the new URL structure. Verify that the hash.txt file is indeed located directly at the root of these URLs.
…ions/checkout (which was v1 and was deprecated 2025-02-01)
jkachel
changed the title
What are the relevant tickets?
Partially closes https://github.com/mitodl/hq/issues/6236
What's this PR do?
Changes the hash URL for the UE frontend to make doof look in the right place for it.
Also: the CI workflow used
actions/cache@v1, which (along with v2) has been deprecated and removed as of Feb 1, 2025. So, this updates it to 4.2.2, and updatesactions/checkoutandactions/setup-pythonas well. I've also pinned these to specific SHAs for security hardening.How should this be manually tested?
After getting your environment set up for local command line use, you should be able to do
python bot-local.py doof-ue-frontend release notesand get stuff back. (The deploy is pretty behind right now so there's a lot of stuff to release.)