Skip to content

Change the frontend hash URL for UE; fix deprecated CI actions and pin to commits #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2025
Merged

Change the frontend hash URL for UE; fix deprecated CI actions and pin to commits #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52fe02e
Change the frontend hash URL
jkachel Mar 17, 2025
2c8df7e
Pin used actions to commits; update them to the latest, including act…
jkachel Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,18 @@ jobs:
runs-on: ubuntu-20.04

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

- name: Set up JS requirements
run: npm install

- name: Set up Python
uses: actions/setup-python@v2
uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
with:
python-version: "3.9"

- id: cache
uses: actions/cache@v1
uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf # v4.2.2
with:
path: ~/.cache/pip
key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt', '**/test_requirements.txt') }}
Expand Down
8 changes: 4 additions & 4 deletions repos_info.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@
"name": "unified-ecommerce",
"repo_url": "https://github.com/mitodl/unified-ecommerce.git",
"ci_hash_url": "https://api-pay-ci.ol.mit.edu/static/hash.txt",
"rc_hash_url": "https://api-pay-rc.ol.mit.edu/static/hash.txt",
"rc_hash_url": "https://api-pay-qa.ol.mit.edu/static/hash.txt",
Comment on lines 193 to +194
Copy link

@gemini-code-assist gemini-code-assist bot Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The change from api-pay-rc.ol.mit.edu to api-pay-qa.ol.mit.edu for the rc_hash_url seems correct, aligning with the QA environment. Double-check that this is the intended environment for release candidate hash URLs.

"prod_hash_url": "https://api-pay.ol.mit.edu/static/hash.txt",
"channel_name": "doof-ue-backend",
"project_type": "web_application",
Expand All @@ -201,9 +201,9 @@
{
"name": "unified-ecommerce-frontend",
"repo_url": "https://github.com/mitodl/unified-ecommerce-frontend.git",
"ci_hash_url": "https://pay-ci.ol.mit.edu/static/hash.txt",
"rc_hash_url": "https://pay-rc.ol.mit.edu/static/hash.txt",
"prod_hash_url": "https://pay.ol.mit.edu/static/hash.txt",
"ci_hash_url": "https://pay-ci.ol.mit.edu/hash.txt",
"rc_hash_url": "https://pay-qa.ol.mit.edu/hash.txt",
"prod_hash_url": "https://pay.ol.mit.edu/hash.txt",
Comment on lines +204 to +206
Copy link

@gemini-code-assist gemini-code-assist bot Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The removal of /static/ from the ci_hash_url and rc_hash_url for the frontend repository seems correct, aligning with the new URL structure. Verify that the hash.txt file is indeed located directly at the root of these URLs.

"channel_name": "doof-ue-frontend",
"project_type": "web_application",
"web_application_type": "django",
Expand Down
Loading