Skip to content

fix: remove unused filters object from useUrlParams hook #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mitoperni merged 1 commit into from
Feb 9, 2026
Merged

fix: remove unused filters object from useUrlParams hook #52

mitoperni merged 1 commit into from
Feb 9, 2026

Conversation

@mitoperni
Copy link
Owner

@mitoperni mitoperni commented Feb 9, 2026 •
edited by devin-ai-integration bot
Loading

Description

Remove unused filters object from useUrlParams hook. The getFilters() callback created a new object on every render, but filters was never consumed by any component — only in tests.

Type of Change

  • Refactoring

Changes Made

  • Removed getFilters useCallback and filters from the hook return value
  • Updated tests to assert on searchValue and countryValue instead of filters

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • No TypeScript errors
  • Tests added/updated
  • All CI checks pass
Open with Devin

@vercel
Copy link

vercel bot commented Feb 9, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cyclemap Ready Ready Preview, Comment Feb 9, 2026 3:38pm

devin-ai-integration[bot]
devin-ai-integration bot reviewed Feb 9, 2026
View reviewed changes
Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@mitoperni mitoperni self-assigned this Feb 9, 2026
@mitoperni mitoperni merged commit cf2103b into main Feb 9, 2026
6 checks passed
@mitoperni mitoperni deleted the fix/remove-unused-filters branch February 10, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

Assignees

@mitoperni mitoperni

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mitoperni