refactor(cmd/mitosisd): update genesis validator command #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced `add-genesis-validator` command with `add-validator` for consistency across the codebase. - Updated initialization scripts in `init.sh` and `setup.sh` to reflect the new command structure. - Enhanced the `initRootCmd` function to properly integrate the updated genesis validator command, ensuring seamless command execution during initialization. These changes improve the clarity and usability of the command-line interface for managing genesis validators in the Mitosis chain.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the genesis validator command structure for consistency, moving from a top-level command to a subcommand under the genesis group.
- Renamed command from
mitosisd add-genesis-validatortomitosisd genesis add-validator - Updated command structure to group genesis-related commands together
- Updated all references in setup scripts to use the new command syntax
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| x/evmvalidator/client/cli/genesis.go | Updated command name and example usage in help text |
| cmd/mitosisd/cmd/commands.go | Moved command from root level to genesis subcommand group |
| infra/localnet/mitosisd/setup.sh | Updated script to use new command syntax |
| infra/devnet/mitosisd/init.sh | Updated script to use new command syntax |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
taeguk
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
mitosisd add-genesis-validatorAfter:
mitosisd genesis add-validatorFor consistency