Skip to content

Conversation

@dbadoy
Copy link
Member

@dbadoy dbadoy commented Apr 7, 2025

Allow overwriting future ValidatorRewardEmission, one modified rule

  • applyFrom <= timestamp -> applyFrom < timestamp

@codecov
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@dbadoy dbadoy marked this pull request as ready for review April 7, 2025 09:18
Copy link
Member

@byeongsu-hong byeongsu-hong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, We'll gonna not to allow modification of emissions that not finalized yet?

@dbadoy
Copy link
Member Author

dbadoy commented Apr 7, 2025

So, We'll gonna not to allow modification of emissions that not finalized yet?

Thank you for mentioning that.
I'm not sure that the benefits will be worth such a significant semantic change. This is because the epoch period probably won't be that long, for example one week.
Also, config settings will go through the Governance voting period and Timelock minDelay, which makes me feel that the advantages of changing emissions for such a short period don't seem that significant.

@dbadoy dbadoy requested a review from byeongsu-hong April 8, 2025 04:53
@dbadoy dbadoy merged commit 049c83f into main Apr 8, 2025
2 checks passed
@dbadoy dbadoy deleted the feat/allow-overwrite branch April 8, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants