Fix navlayers-technique and navlayers-layerobj metadata setter#65
Closed
pljoel wants to merge 3 commits intomitre-attack:developfrom
Closed
Fix navlayers-technique and navlayers-layerobj metadata setter#65pljoel wants to merge 3 commits intomitre-attack:developfrom
pljoel wants to merge 3 commits intomitre-attack:developfrom
Conversation
pljoel
changed the title
Contributor
|
This is really clean code and definitely solves the original issue! Unfortunately, I can't quite merge it in its current state - we need to still support creation of metadata/metadiv objects from dictionaries (backwards compatibility requirements). That being said, adding that functionality back in should be quite easy using the base you've proposed here. |
Merged
Contributor
|
This has been closed in favor of #66, which uses it as a base. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #63