Corrected Oracle create script #1405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1405 +/- ##
=========================================
Coverage 25.21% 25.21%
Complexity 912 912
=========================================
Files 209 209
Lines 11689 11689
Branches 2116 2116
=========================================
Hits 2947 2947
Misses 8227 8227
Partials 515 515Continue to review full report at Codecov.
|
Member
|
I'm not an oracle expert and have no means of testing this, so as with other Oracle DB stuff I'm going to have to trust that this is correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The oracle create script doesn't properly cleanup after itself if re-run.