Fix Content::walk not being recursive#80
Merged
mitsuhiko merged 1 commit intomitsuhiko:masterfrom Oct 20, 2019
LPGhatguy:fix-content-walk
Merged
Fix Content::walk not being recursive#80mitsuhiko merged 1 commit intomitsuhiko:masterfrom LPGhatguy:fix-content-walk
mitsuhiko merged 1 commit intomitsuhiko:masterfrom
LPGhatguy:fix-content-walk
Conversation
LPGhatguy
added a commit
to rojo-rbx/rojo
that referenced
this pull request
Oct 21, 2019
Map sorting in Insta was previously not recursive. As of this PR, it is! mitsuhiko/insta#80 Since it hasn't made it into a release yet, but is important for Rojo to have snapshot determinism, we're moving temporarily to depend on Insta via Git.
Dekkonot
pushed a commit
to UpliftGames/rojo
that referenced
this pull request
Jan 11, 2024
Map sorting in Insta was previously not recursive. As of this PR, it is! mitsuhiko/insta#80 Since it hasn't made it into a release yet, but is important for Rojo to have snapshot determinism, we're moving temporarily to depend on Insta via Git.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content::walkclaims to be recursive, but actually isn't! This caused thesort_mapsfeature to only affect maps at the top level, which is causing snapshot nondeterminism in one of my projects.Additionally, three tuple-related variants were not present. I don't think I had these present in my projects, but it seems they were omitted by error.
I changed
walkto accept thevisitcallback via a reference instead of by value like before, since now that reference needs to be passed through multiple calls toSelf::walkand cannot be moved.