test: add CLI test suite and test datasets#2
Merged
Conversation
All Excel files are stored in "tests/data"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces an initial testing setup for the CLI, including dataset fixtures and development dependencies. It establishes a foundation for validating functionality and preventing regressions.
Changes Made
Test Suite
pytestandCliRunnerTest Data
tests/datafor various scenarios:NULLvalues) and header-only filesNote
Inside test suite module, there's a test function which converts an empty Excel file into CSV, but the test itself will returns success due to the Excel file having a sheet. The tool will only fails if the Excel file has no sheet at all, throwing
xls2csv.exception.NoSheetFoundErrorexception.Development Dependencies
pytestas a development dependency inpyproject.tomlpytesttorequirements.txtImpact
Summary
This PR sets up a basic but practical testing framework for the CLI, backed by realistic Excel datasets. It provides a starting point for expanding test coverage and improving code quality over time.